Saved locations #105

amyfromandi · 2024-12-16T20:10:21Z

Merging the database schema setup for the saved_locations user features

…to saved_locations

davenquinn

Generally this looks good but there are some changes that might make a stronger schema design.

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

davenquinn · 2024-12-18T19:06:55Z

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

+    longitude            numeric                 not null,
+    created_at           timestamp default now() not null,
+    updated_at           timestamp default now() not null,
+    category             saved_locations_enum


Should this be an enum or a link to a related table? the nice thing about the latter is that it is easier to update and can have "details" (e.g., an explanation of what the category means, a symbol ID, etc.) attached.

This is a great question. I think having set categories as an enum type so that the user can quickly select...and then have a separate tags table so that the user can define and search by their locations using their own tag definitions. I'll add this to the schema to get your thoughts.

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

davenquinn · 2024-12-18T19:09:24Z

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

+alter table saved_locations
+    owner to "macrostrat-admin";
+
+grant delete, insert, select, update on saved_locations to web_anon;


Do we want anonymous users to be able to delete and insert locations? We could lock this down a bit more even without implementing row-level security...

My thoughts were to only give CRUD ops only to authorized users and not web_anon. Does web_anon require a login to access macrostrat? If not, I would assume they wouldn't get access to the saved_locations feature at all?

davenquinn · 2024-12-18T19:15:19Z

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

+    location_name        varchar(120)            not null,
+    location_description text,
+    latitude             numeric                 not null,
+    longitude            numeric                 not null,


How will you decide how far to zoom in for specific saved locations? Is this something that needs to be saved in the database?

Maybe we could add a view_params JSON column to house view parameters in a less structured way?

We could alternatively/additionally set a radius value that would define whether the location was small or large

The Zoom level/radius is mostly only a problem because we can add locations from a very zoomed out perspective, so maybe the solution would be to just disallow that in the UI.

I've stored this as an additional text column for now. I'm going to look into the how we can take these extra params, transform them into json and import them into the db.

I think having optional radius (number in meters) and camera_position (JSON column with format matching https://github.com/UW-Macrostrat/web-components/blob/3f7eb7aa9e1c38dca0d2689d9a127a67a2cd7e05/packages/mapbox-utils/src/position.ts#L13) would do nicely.

If we store the elevation of the point, we can infer the camera position from pitch and bearing also, so maybe that's better.

cli/macrostrat/cli/subsystems/user_features/update_saved_locations.sql

davenquinn · 2025-02-20T20:27:23Z

We could go ahead and attempt to integrate row-level security here, or save it for another pull request
It would be great to package this as a migration, but that can also be another pull request

davenquinn

Location information updates

davenquinn · 2025-02-20T20:40:46Z

cli/macrostrat/cli/subsystems/user_features/saved_locations_schema.sql

+            references macrostrat_auth."user",
+    location_name        varchar(120)            not null,
+    location_description text,
+    latitude             numeric                 not null,


Latitude and longitude should be changed to a point geometry with SRID 4326. Geometry(Point, 4326)

…_locations

amyfromandi · 2025-03-24T17:36:21Z

Saved locations feature is added to the migrations code here

amyfromandi · 2025-04-08T16:23:23Z

@davenquinn The user_locations migration now successfully runs. Additionally, all CRUD operations work via the PostgREST API using web_anon. We are ready for the front-end development, unless we need any custom v3 endpoints created beyond the ones listed below. We'll need to address authentication and RLS for particular users as well.

Migrations:
- baseline:               already applied
- macrostrat-api:         already applied
**- user-saved-locations:   should be applied**
- integrations-tables:    already applied
- points:                 already applied
- macrostrat-mariadb:     already applied
- map-source-slug:        already applied
- ingest-state-type:      already applied
- maps-scale-type:        already applied
- maps-lines-oriented:    already applied
- api-v3:                 already applied
- macrostrat-tileserver:  already applied
- maps-sources-api:        always applied
- maps-source-operations: already applied
- storage-scheme:         already applied
- ingest-metadata:        already applied
- macrostrat-core-v2:     already applied
- macrostrat-tile-layers:  always applied
- map-ingestion-api:      already applied
- partition-maps:         already applied
- column-builder:         already applied
- partition-carto:        already applied
- maps-sources:           already applied

Applied 3 migrations in 165.18 seconds
Completed: ['baseline', 'macrostrat-api', 'integrations-tables',
'points', 'macrostrat-mariadb', 'map-source-slug',
'ingest-state-type', 'maps-scale-type', 'maps-lines-oriented',
'api-v3', 'macrostrat-tileserver', 'maps-source-operations',
'storage-scheme', 'ingest-metadata', 'macrostrat-core-v2',
'map-ingestion-api', 'partition-maps', 'column-builder',
'partition-carto', 'maps-sources', **'user-saved-locations'**,
'maps-sources-api', 'macrostrat-tile-layers']

These are the PostGREST URL examples that work:
POST https://dev2.macrostrat.org/api/pg/user_locations
example json:

{
  "user_id": 46,
  "name": "Volcanic Cone Rim",
  "description": "Overlook point on rim of extinct volcanic cone.",
  "point": "SRID=4326;POINT(-155.292 19.406)",
  "zoom": 15.0,
  "meters_from_point": 80.0,
  "elevation": 2395.0,
  "azimuth": 30.0,
  "pitch": -5.0,
  "map_layers": ["satellite", "geology", "elevation"]
}

GET https://dev2.macrostrat.org/api/pg/user_locations
PATCH https://dev2.macrostrat.org/api/pg/user_locations?id=eq.{{id to update here}}
PUT https://dev2.macrostrat.org/api/pg/user_locations?id=eq.{{id to update here}}
DELETE https://dev2.macrostrat.org/api/pg/user_locations?id=eq.{{id to delete here}}

amyfromandi added 3 commits October 18, 2024 14:16

created saved_locations branch

9ebf79f

added saved_locations schema, permissions, and view queries

b781a7b

Merge branch 'main' of https://github.com/UW-Macrostrat/macrostrat in…

d6166cf

…to saved_locations

davenquinn reviewed Dec 18, 2024

View reviewed changes

davenquinn mentioned this pull request Dec 19, 2024

User features - saved locations UW-Macrostrat/web#260

Merged

7 tasks

modified the schema for better architecture

6230fbf

davenquinn reviewed Feb 20, 2025

View reviewed changes

amyfromandi and others added 9 commits February 21, 2025 14:13

updated schema for user_locations

36fbfad

got command line to word

71187a6

Merge branch 'main' of github.com:UW-Macrostrat/macrostrat into saved…

77a9a3c

…_locations

merging main into saved_locations

a7db996

adding migrations files for saved_locations

67c039c

merging main into saved_locations

a8a6725

updating stuff

a676e3b

created user features saved locations

06a4e08

Format code and sort imports

2fe4b8d

amyfromandi requested a review from davenquinn March 24, 2025 17:35

amyfromandi merged commit cf24572 into main Mar 24, 2025

amyfromandi deleted the saved_locations branch March 24, 2025 17:40

Saved locations #105

Saved locations #105

Uh oh!

Conversation

amyfromandi commented Dec 16, 2024

Uh oh!

davenquinn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amyfromandi Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davenquinn commented Feb 20, 2025

Uh oh!

davenquinn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amyfromandi commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amyfromandi commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amyfromandi Feb 20, 2025 •

edited

Loading

amyfromandi commented Mar 24, 2025 •

edited

Loading